Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify copy to clipboard icon with docs.rs, rustdoc and crates.io #2421

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 1, 2024

It looks like this:

image

All colors are the same. I computed the filter values with https://isotropic.co/tool/hex-color-to-css-filter/ (very nice website).

Another change you might have noticed: I increased the size of the buttons. There are two reasons for this change:

  1. The new clipboard icon rendered badly with such small dimensions.
  2. Since these buttons can be used on mobile devices, making them bigger will make things better for everyone.

@camelid
Copy link
Member

camelid commented Aug 1, 2024

The new button looks out of proportion with the others - maybe make the others a little smaller to match it better?

@GuillaumeGomez
Copy link
Member Author

Updated! You can see the new display in the first comment.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/theme/css/chrome.css Outdated Show resolved Hide resolved
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss added this pull request to the merge queue Aug 14, 2024
Merged via the queue into rust-lang:master with commit 5194d2b Aug 14, 2024
11 checks passed
@GuillaumeGomez GuillaumeGomez deleted the copy-code branch August 14, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants